Fix possible truncation of particle optical properties values#491
Merged
Fix possible truncation of particle optical properties values#491
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #491 +/- ##
==========================================
- Coverage 91.92% 91.88% -0.04%
==========================================
Files 56 56
Lines 2564 2552 -12
Branches 144 144
==========================================
- Hits 2357 2345 -12
Misses 132 132
Partials 75 75 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
slayoo
reviewed
Apr 24, 2026
slayoo
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #469. Particle optical properties were returning a scalar value when the fortran code was fetching and returning an array. Typically this of size 1 so it wasn't noticeable.
All 5 calls for particle properties now return a std::valarray of the correct type (either real or complex) using the templates for arrays. Tests were expanded to operate to handle the possibility of multiple wavelengths.